From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WkCS0-0000Vk-Dm
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:09:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WkCRu-0003xH-9Q
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:08:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26708)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WkCRu-0003x6-2G
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:08:50 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4DD8mf9016597
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 13 May 2014 09:08:48 -0400
Date: Tue, 13 May 2014 15:08:46 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140513130846.GA30562@stefanha-thinkpad.redhat.com>
References: <1399899851-5641-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1399899851-5641-1-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] qcow1: Input validation fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, ppandit@redhat.com

On Mon, May 12, 2014 at 03:04:06PM +0200, Kevin Wolf wrote:
> Kevin Wolf (5):
>   qcow1: Make padding in the header explicit
>   qcow1: Check maximum cluster size
>   qcow1: Validate L2 table size (CVE-2014-0222)
>   qcow1: Validate image size (CVE-2014-0223)
>   qcow1: Stricter backing file length check
> 
>  block/qcow.c               | 44 +++++++++++++++++++----
>  tests/qemu-iotests/092     | 90 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/092.out | 30 ++++++++++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 158 insertions(+), 7 deletions(-)
>  create mode 100755 tests/qemu-iotests/092
>  create mode 100644 tests/qemu-iotests/092.out

Looks good overall.  No Reviewed-by yet because I'm curious about the
answer to Benoit's questions about the poke_file constants.

Stefan