From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkSyv-0000jq-Hh for qemu-devel@nongnu.org; Wed, 14 May 2014 02:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkSyn-0004xa-Sp for qemu-devel@nongnu.org; Wed, 14 May 2014 02:48:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkSyn-0004xO-LY for qemu-devel@nongnu.org; Wed, 14 May 2014 02:47:53 -0400 Date: Wed, 14 May 2014 03:47:28 -0300 From: Marcelo Tosatti Message-ID: <20140514064728.GA6064@amt.cnet> References: <1399297882-3444-1-git-send-email-agraf@suse.de> <20140508013325.GA5474@amt.cnet> <536B3079.7060109@suse.de> <20140509022831.GB21213@amt.cnet> <536CC1BC.2000302@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <536CC1BC.2000302@redhat.com> Subject: Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org On Fri, May 09, 2014 at 01:53:32PM +0200, Paolo Bonzini wrote: > Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: > >Alex, > > > >Unability to upgrade systems is not an excuse to fix the bug in the > >wrong place. > > It may be an excuse to fix the bug in both places though. > > Paolo Actually, its messy to fix this in kernel, because its necessary to read TSC MSR of a remote vcpu. So it seems more appropriate to do this in QEMU. Sorry for the noise. Alexander, can you resend without the printf? Also checking for "larger than" is not necessary as discussed because it is always true.