From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkTsM-0004Ev-0g for qemu-devel@nongnu.org; Wed, 14 May 2014 03:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkTsH-0008Hf-6y for qemu-devel@nongnu.org; Wed, 14 May 2014 03:45:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkTsG-0008HY-Uo for qemu-devel@nongnu.org; Wed, 14 May 2014 03:45:13 -0400 Date: Wed, 14 May 2014 09:44:04 +0200 From: Kevin Wolf Message-ID: <20140514074404.GA3610@noname.redhat.com> References: <1400015466-16048-1-git-send-email-ncmike@ncultra.org> <5372932A.40001@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <5372932A.40001@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, Mike Day , stefanha@redhat.com, cornelia.huck@de.ibm.com --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 13.05.2014 um 23:48 hat Eric Blake geschrieben: > On 05/13/2014 03:11 PM, Mike Day wrote: >=20 > Subject line could have used a [PATCHv2] designation to make it obvious > this is a fixed version. But that doesn't affect what goes into git. >=20 > > g_sequence_lookup is not supported by glib < 2.28. The usage > > of g_sequence_lookup is not essential in this context (it's a > > safeguard against duplicate values in the help message). > > Removing the call enables the build on all platforms and > > does not change the operation of the help function. > >=20 > > Signed-off-by: Mike Day > > --- > > qemu-img.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > Reviewed-by: Eric Blake Thanks, applied to the block branch. Kevin --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcx7EAAoJEH8JsnLIjy/Wgz8P/jbz+XqtmdVGk9J8EhEAtoDu PFljCV39+u7056+9r7Rw0njLRo316Ag8/JW78K0n8iobvbYGr9ueTSc7esn2B42O Nq3uW42S2i0pJaQlG9MCSPRLMVmdtbs7cMvbVyoKauwHXGimj8HIvoUc+OLtdlPl NlnTp0O871uqndxcPa3T9GRL+UoQFHgUVqEhm+2DTZ7FvVSR12Ze8E55TJzWJLuU f6/cEHMbMSW5/o3E/X2sk4J4zcpmwQA1OrLJcmVs8gGBIZdgl6H7bqogBTTqf7Jd JLoyc55k4rhElqM2ml2CFCO9L1gHZmXzbXROsnxL7A9cCm3pvQgW/A17EEJ45uI3 oFkIIlw2HdeYxHj+0eZBKizVjFveNAu6wgyV2lVA+IDGGRGcM/NJi51FYbczw0P8 5er/E671bqTDSj27ES5MarOzrYB26Fuc83D0FPzNryiZUx+G/nb8jfOqbKZsZLlb bs4YwsbaSZpS5oswiF3xEa3sNk0d7jg2/JRPlNkRSC2HJVmsbdbebzNsl2iTIiTi l5lUPj75Atlyb0cEasodrdee70BjsUe3U7+92Ecucj92rWORcZgeQ6pVqF4Voxk6 xxCSoEUbRANfobugyyZUMjYUCdcxlKi5MZr7bQD1eVpd1yxRWSXZEeZqNm9xGimv W+df/2ut4nHTXHKoTpMV =acb9 -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--