From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkTxq-0007Jn-Rd for qemu-devel@nongnu.org; Wed, 14 May 2014 03:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkTxm-0001q5-2X for qemu-devel@nongnu.org; Wed, 14 May 2014 03:50:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkTxl-0001pz-R3 for qemu-devel@nongnu.org; Wed, 14 May 2014 03:50:53 -0400 Date: Wed, 14 May 2014 09:50:46 +0200 From: Kevin Wolf Message-ID: <20140514075046.GC3610@noname.redhat.com> References: <1399997268-9889-1-git-send-email-ncmike@ncultra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399997268-9889-1-git-send-email-ncmike@ncultra.org> Subject: Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanha@redhat.com Am 13.05.2014 um 18:07 hat Mike Day geschrieben: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints the formats in sorted order, making it > easier to read and to find a specific format in the list. > > [Added suggestions from Fam Zheng to declare variables > at the top of the scope in help() and to omit explicit cast for void* > opaque. > --Stefan] > > [Removed call to g_sequence_lookup because it breaks the build on > machines with glib < 2.28. > --Mike] > > Signed-off-by: Mike Day > Signed-off-by: Stefan Hajnoczi What happened here? This patch seems to be already applied, and you included Stefan's SoB as well. Kevin