From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkUEE-0006LR-8O
	for qemu-devel@nongnu.org; Wed, 14 May 2014 04:08:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkUE8-0000J1-4o
	for qemu-devel@nongnu.org; Wed, 14 May 2014 04:07:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkUE7-0000Iv-Tu
	for qemu-devel@nongnu.org; Wed, 14 May 2014 04:07:48 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4E87kGi007366
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 14 May 2014 04:07:47 -0400
Date: Wed, 14 May 2014 10:07:43 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140514080743.GE3610@noname.redhat.com>
References: <cover.1399989040.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1399989040.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Accommodate VHDX images created by
	Disk2VHD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Am 13.05.2014 um 16:00 hat Jeff Cody geschrieben:
> This series adds support for VHDX images created with Microsofts p2v tool Disk2VHD.
> 
> Jeff Cody (2):
>   block: vhdx - account for identical header sections
>   block: add test for vhdx image created by Disk2VHD
> 
>  block/vhdx.c                                            |   9 ++++++++-
>  tests/qemu-iotests/070                                  |   7 +++++++
>  tests/qemu-iotests/070.out                              |   7 +++++++
>  tests/qemu-iotests/sample_images/test-disk2vhd.vhdx.bz2 | Bin 0 -> 1424 bytes
>  4 files changed, 22 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemu-iotests/sample_images/test-disk2vhd.vhdx.bz2

Thanks, applied to the block branch.

Unrelated bug I noticed while testing this: The old error message for
opening the image was 'qemu-img: Could not open 'TEST_DIR/test-disk2vhd.
vhdx': No valid VHDX header found: Unknown error -4096'.

This is because vhdx_parse_header() doesn't set ret before jumping to
fail: while trying to find the current header.

Kevin