From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Benoît Canet" <benoit@irqsave.net>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Max Reitz" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames
Date: Wed, 14 May 2014 12:52:19 +0200 [thread overview]
Message-ID: <20140514105219.GF3610@noname.redhat.com> (raw)
In-Reply-To: <537298EB.8010704@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
Am 14.05.2014 um 00:12 hat Eric Blake geschrieben:
> On 05/08/2014 12:12 PM, Max Reitz wrote:
> > If the filename given to bdrv_open() is prefixed with "json:", parse the
> > rest as a JSON object and merge the result into the options QDict. If
> > there are conflicts, report one of them to the user and abort.
>
> Commit message is stale compared to change in the code.
Changed the last sentence as follows:
"If there are conflicts, the options QDict takes precedence."
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-14 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:12 [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames Max Reitz
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 1/4] qdict: Add qdict_join() Max Reitz
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 2/4] check-qdict: Add test for qdict_join() Max Reitz
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames Max Reitz
2014-05-13 22:12 ` Eric Blake
2014-05-14 10:52 ` Kevin Wolf [this message]
2014-05-08 18:12 ` [Qemu-devel] [PATCH v3 4/4] iotests: Add test for the JSON protocol Max Reitz
2014-05-13 22:21 ` Eric Blake
2014-05-19 14:25 ` Kevin Wolf
2014-05-14 10:52 ` [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514105219.GF3610@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit@irqsave.net \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).