From: Stefan Hajnoczi <stefanha@gmail.com>
To: Zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: Zhouxiangjiu <zhouxiangjiu@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Juan Quintela <quintela@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
Alex Williamson <alex.williamson@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Amos Kong <akong@redhat.com>, Dave Gilbert <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused
Date: Wed, 14 May 2014 14:30:26 +0200 [thread overview]
Message-ID: <20140514123026.GA16683@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <D1BD20B5DB34024DA951CEEE6C4C59985962892B@szxema505-mbs.china.huawei.com>
On Thu, May 08, 2014 at 12:51:05PM +0000, Zhanghailiang wrote:
> > If you implement this in the net layer then that problem is easy to resolve since
> > we can flush all queues when the guest resumes to get packets flowing again.
> >
> Do you mean we should also listen for VM runstate changes in net layer, and when detect runstate changes back to running , we flush all queues actively? Am I misunderstanding?
> Or we can do it *before* qemu (exactly when it check if it can send packets) send packets to guest again, this way will be simple, but it also need know the change of runstate. Any idea?
When the runstate changes back to running, we definitely need to flush
queues to get packets flowing again. I think the simplest way of doing
that is in the net layer so individual NICs and netdevs don't have to
duplicate this code.
Stefan
next prev parent reply other threads:[~2014-05-14 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398507552-50168-1-git-send-email-zhang.zhanghailiang@huawei.com>
[not found] ` <20140426104415.GB2389@amosk.info>
[not found] ` <CAFEAcA_fBi1TuuvTwXHEKJ5zOw7teDB_6JOwBMMCLumw7_fgVQ@mail.gmail.com>
[not found] ` <CAEgOgz5mnaY8V8SeJ0WuSof8j2wYSWGXb=FW4erkqM39r3xQ-g@mail.gmail.com>
[not found] ` <D1BD20B5DB34024DA951CEEE6C4C59985962636A@szxema505-mbs.china.huawei.com>
2014-05-06 12:55 ` [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused Stefan Hajnoczi
2014-05-08 12:51 ` Zhanghailiang
2014-05-14 12:30 ` Stefan Hajnoczi [this message]
2014-05-14 12:46 ` Michael S. Tsirkin
2014-05-26 11:48 ` Stefan Hajnoczi
2014-05-26 11:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514123026.GA16683@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=akong@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhouxiangjiu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).