From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYQW-0004BX-PU
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:37:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYQN-0006dw-Bh
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:36:52 -0400
Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:61511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYQN-0006dg-5G
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:36:43 -0400
Received: by mail-wg0-f46.google.com with SMTP id n12so1865471wgh.5
	for <qemu-devel@nongnu.org>; Wed, 14 May 2014 05:36:42 -0700 (PDT)
Date: Wed, 14 May 2014 14:36:39 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140514123639.GC16683@stefanha-thinkpad.redhat.com>
References: <1399662217-31148-1-git-send-email-stefanha@redhat.com>
	<1399662217-31148-13-git-send-email-stefanha@redhat.com>
	<5370F1AB.2070502@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5370F1AB.2070502@redhat.com>
Subject: Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors
 when volume isn't accessible
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Krempa <pkrempa@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, May 12, 2014 at 10:07:07AM -0600, Eric Blake wrote:
> On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote:
> > From: Peter Krempa <pkrempa@redhat.com>
> > 
> > The docs for glfs_init suggest that the function sets errno on every
> > failure. In fact it doesn't. As other functions such as
> > qemu_gluster_open() in the gluster block code report their errors based
> > on this fact we need to make sure that errno is set on each failure.
> > 
> > This fixes a crash of qemu-img/qemu when a gluster brick isn't
> > accessible from given host while the server serving the volume
> > description is.
> > 
> > Thread 1 (Thread 0x7ffff7fba740 (LWP 203880)):
> >  #0  0x00007ffff77673f8 in glfs_lseek () from /usr/lib64/libgfapi.so.0
> >  #1  0x0000555555574a68 in qemu_gluster_getlength ()
> >  #2  0x0000555555565742 in refresh_total_sectors ()
> >  #3  0x000055555556914f in bdrv_open_common ()
> >  #4  0x000055555556e8e8 in bdrv_open ()
> >  #5  0x000055555556f02f in bdrv_open_image ()
> >  #6  0x000055555556e5f6 in bdrv_open ()
> >  #7  0x00005555555c5775 in bdrv_new_open ()
> >  #8  0x00005555555c5b91 in img_info ()
> >  #9  0x00007ffff62c9c05 in __libc_start_main () from /lib64/libc.so.6
> >  #10 0x00005555555648ad in _start ()
> > 
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> 
> Isn't this missing S-o-b from Peter?

Good catch.  Peter, can you send your Signed-off-by: please?

Stefan