From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYUN-0006X2-8I
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:41:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYUD-000868-6I
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:40:51 -0400
Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:37348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WkYUC-00085x-J6
	for qemu-devel@nongnu.org; Wed, 14 May 2014 08:40:40 -0400
Received: by mail-wi0-f179.google.com with SMTP id bs8so2302405wib.6
	for <qemu-devel@nongnu.org>; Wed, 14 May 2014 05:40:39 -0700 (PDT)
Date: Wed, 14 May 2014 14:40:36 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140514124036.GD16683@stefanha-thinkpad.redhat.com>
References: <1399739757-3111-1-git-send-email-juli@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1399739757-3111-1-git-send-email-juli@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] snapshot: fixed
 bdrv_get_full_backing_filename can not get correct full_backing_filename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jun Li <juli@redhat.com>
Cc: kwolf@redhat.com, junmuzi@gmail.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Sun, May 11, 2014 at 12:35:57AM +0800, Jun Li wrote:
> From: Jun Li <junmuzi@gmail.com>
> 
> This patch fixed the following bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1084302 .
> 
> path_combine can not calculate the correct full path name for backing_file.
> Such as:
> create a snapshot chain:
> sn2->sn1->$BASE_IMG
> backing file is : /home/wookpecker/img.qcow2
> sn1 : /home/woodpecker/tmp/sn1
> sn2 : /home/woodpecker/tmp/sn2
> when create sn2, path_combine can not got a correct path for $BASE_IMG.
> 
> In this patch, will check the backing_filename is a symlink or not firstly,
> then return the full(absolute) path via realpath.
> 
> Signed-off-by: Jun Li <junmuzi@gmail.com>
> ---
>  block.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

Please fix your patch email submission process so it doesn't send the
same patch multiple times.

You've done this several times in the past.  It makes patch review more
difficult than it needs to be for reviewers.  If I have to compare
several emails and figure out which patch is the right one before
reviewing I'm inclined not to review at all.

Thanks,
Stefan