From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkZW8-0006jO-UY for qemu-devel@nongnu.org; Wed, 14 May 2014 09:46:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkZW2-0007Xh-A6 for qemu-devel@nongnu.org; Wed, 14 May 2014 09:46:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkZW2-0007Wv-1Z for qemu-devel@nongnu.org; Wed, 14 May 2014 09:46:38 -0400 Date: Wed, 14 May 2014 09:46:28 -0400 From: Jeff Cody Message-ID: <20140514134628.GA11553@localhost.localdomain> References: <1399662217-31148-1-git-send-email-stefanha@redhat.com> <1399662217-31148-4-git-send-email-stefanha@redhat.com> <20140513161849.08628e6c.cornelia.huck@de.ibm.com> <20140514123548.GB16683@stefanha-thinkpad.redhat.com> <20140514134000.GC19672@T430.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140514134000.GC19672@T430.nay.redhat.com> Subject: Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Peter Maydell , Stefan Hajnoczi , "qemu-devel@nongnu.org" , Mike Day , Stefan Hajnoczi , Cornelia Huck On Wed, May 14, 2014 at 09:40:00PM +0800, Fam Zheng wrote: > On Wed, 05/14 09:27, Mike Day wrote: > > On Wed, May 14, 2014 at 8:35 AM, Stefan Hajnoczi wrote: > > > Jeff Cody recently wanted to eliminate duplicate entries in the list. I > > > thought part of your intention was to address the duplicates with your > > > patch. > > > > > > We can back out the sequence API if it's not supported on older glib but > > > it would be nice to eliminate duplicates later, too. > > > > I agree. I can submit an additional patch that uses an older API. > > What, exactly is the cause of duplicate entries in the list? > > For example in protocol drivers, multiple BlockDrivers are registered with the > same format name, although the protocol names are different: > > nbd > gluster > sheepdog > > In my build I see 3 nbd's. > > Fam Duplicates should no longer be printed on qemu/master - commit e855e4fb7b has been applied, as of April 29th 2014.