From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdsR-0007Zh-Qd for qemu-devel@nongnu.org; Wed, 14 May 2014 14:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkdsM-0003uB-8X for qemu-devel@nongnu.org; Wed, 14 May 2014 14:26:03 -0400 Date: Wed, 14 May 2014 14:25:16 -0400 From: Luiz Capitulino Message-ID: <20140514142516.20269803@redhat.com> In-Reply-To: <1400088577.14303.45.camel@localhost.localdomain> References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-3-git-send-email-marcel.a@redhat.com> <53725800.3030404@suse.de> <53726D96.8030404@redhat.com> <5373A11E.90005@suse.de> <1400088577.14303.45.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, peter.chubb@nicta.com.au, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, cornelia.huck@de.ibm.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, armbru@redhat.com, michael@walle.cc, qemu-ppc@nongnu.org, pbonzini@redhat.com, Andreas =?UTF-8?B?RsOkcmJlcg==?= , aurelien@aurel32.net On Wed, 14 May 2014 20:29:37 +0300 Marcel Apfelbaum wrote: > On Wed, 2014-05-14 at 19:00 +0200, Andreas F=C3=A4rber wrote: > > Am 13.05.2014 21:08, schrieb Eric Blake: > > > On 05/13/2014 11:36 AM, Andreas F=C3=A4rber wrote: > > >> Am 07.05.2014 16:42, schrieb Marcel Apfelbaum: > > >>> A NULL value is not added to visitor's stack, but there is no > > >>> check for that when the visitor tries to return that value, > > >>> leading to Qemu crash. > > >>>=20 > > >>> Reviewed-by: Eric Blake Signed-off-by: > > >>> Marcel Apfelbaum > > >>=20 > > >> Where does the Rb come from on this v1? Is it in any tree > > >> already? > > >>=20 > > >=20 > > > The (weak) R-b was here:=20 > > > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02861.html > >=20 > > Thanks. > > >=20 > > So Luiz was okay with it too, but his last message seems to be > > indicating this needs to be fixed somewhere else, too: > >=20 > > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05228.html > > https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00217.html > >=20 > > Can/should that be addressed as a follow-up? Or is there a test case > > that breaks? > Simple and "popular" test case: the user does not use the -kernel-cmdline= parameter. > The patch is needed because otherwise the main function will fail > if no value is passed by the user to string parameters.=20 >=20 > Regarding Luiz's concern, it can be a follow-up as I am not aware of > any problem with that. My concern was that I wasn't sure if this is the right fix for the issue or if it's papering over the real bug. I quickly checked the code and it seemed to make sense, but I didn't have time to study it deeper. We could ask Michael Roth or Anthony, but I wouldn't hold this series because of that. Here's my ACK if you need it: Acked-by: Luiz Capitulino