Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

[Kevin Wolf <kwolf@redhat.com>]

Am 14.05.2014 um 16:26 hat Peter Maydell geschrieben:
> Before we write common.env to the tests/qemu-iotests directory, ensure
> that it exists. This fixes out-of-tree builds from clean.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> If somebody would like to review this I'll apply it to master as
> a buildfix...
> 
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 6adfa72..c4e43ed 100755
> --- a/configure
> +++ b/configure
> @@ -4770,6 +4770,7 @@ fi
>  
>  iotests_common_env="tests/qemu-iotests/common.env"
>  
> +mkdir -p "$(dirname "$iotests_common_env")"
>  echo "# Automatically generated by configure - do not modify" > $iotests_common_env
>  echo >> $iotests_common_env
>  echo "PYTHON='$python'" >> $iotests_common_env

We already have an mkdir -p, in the section at line 5161ff. Perhaps we
should just move that to further above?

But as this is a build fix, I don't want to start bikeshedding, so I'm
not objecting to your patch.

Kevin