From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkaaO-0004O6-8w
	for qemu-devel@nongnu.org; Wed, 14 May 2014 10:55:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkaaJ-0006Iz-Et
	for qemu-devel@nongnu.org; Wed, 14 May 2014 10:55:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WkaaJ-0006Hd-7x
	for qemu-devel@nongnu.org; Wed, 14 May 2014 10:55:07 -0400
Date: Wed, 14 May 2014 16:54:55 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140514145455.GN3610@noname.redhat.com>
References: <1400077612-28488-1-git-send-email-peter.maydell@linaro.org>
	<20140514143207.GL3610@noname.redhat.com>
	<CAFEAcA_fNQnCLYe=q-0RZccMMKtQs+AOgBge-Q=5DAPvBxunFw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_fNQnCLYe=q-0RZccMMKtQs+AOgBge-Q=5DAPvBxunFw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests
 exists before writing common.env
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

Am 14.05.2014 um 16:46 hat Peter Maydell geschrieben:
> On 14 May 2014 15:32, Kevin Wolf <kwolf@redhat.com> wrote:
> > Am 14.05.2014 um 16:26 hat Peter Maydell geschrieben:
> >> Before we write common.env to the tests/qemu-iotests directory, ensure
> >> that it exists. This fixes out-of-tree builds from clean.
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >> ---
> >> If somebody would like to review this I'll apply it to master as
> >> a buildfix...
> >>
> >>  configure | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/configure b/configure
> >> index 6adfa72..c4e43ed 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -4770,6 +4770,7 @@ fi
> >>
> >>  iotests_common_env="tests/qemu-iotests/common.env"
> >>
> >> +mkdir -p "$(dirname "$iotests_common_env")"
> >>  echo "# Automatically generated by configure - do not modify" > $iotests_common_env
> >>  echo >> $iotests_common_env
> >>  echo "PYTHON='$python'" >> $iotests_common_env
> >
> > We already have an mkdir -p, in the section at line 5161ff. Perhaps we
> > should just move that to further above?
> >
> > But as this is a build fix, I don't want to start bikeshedding, so I'm
> > not objecting to your patch.
> 
> Yes, there are other mkdirs scattered through the configure
> script that we could perhaps collect up and move to the top
> with that whole section of mkdir/symlink code, as a later
> cleanup.

Sounds good to me.

Kevin