From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WkpOk-0004Ai-AN
	for qemu-devel@nongnu.org; Thu, 15 May 2014 02:44:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WkpOe-0006WY-6B
	for qemu-devel@nongnu.org; Thu, 15 May 2014 02:44:10 -0400
Date: Thu, 15 May 2014 09:42:54 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140515064254.GE14456@redhat.com>
References: <20140514200030.E7E842F456@mono.eik.bme.hu>
	<1400136137.2922.16.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1400136137.2922.16.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of
 pci config to 16550 compatible
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org

On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote:
> On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote:
>        ^^^^^^^^^^
> Looks like your clock is _way_ off.
> 
> > +    if (!pci->compat) {
> > +        pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> > +    }
> 
> >  static Property serial_pci_properties[] = {
> >      DEFINE_PROP_CHR("chardev",  PCISerialState, state.chr),
> > +    DEFINE_PROP_UINT8("compat",  PCISerialState, compat, 0),
> >      DEFINE_PROP_END_OF_LIST(),
> >  };
> 
> > +        {\
> > +            .driver   = "pci-serial",\
> > +            .property = "compat",\
> > +            .value    = stringify(1),\
> > +        },\
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> mst, do you take that through the pci tree?
> 
> cheers,
>   Gerd
> 

Yes but I'd like the property renamed. Agree?