From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wkptb-00064P-NG for qemu-devel@nongnu.org; Thu, 15 May 2014 03:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkptV-0001js-J6 for qemu-devel@nongnu.org; Thu, 15 May 2014 03:16:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkptV-0001jh-A5 for qemu-devel@nongnu.org; Thu, 15 May 2014 03:15:57 -0400 Date: Thu, 15 May 2014 10:14:46 +0300 From: "Michael S. Tsirkin" Message-ID: <20140515071446.GB14659@redhat.com> References: <20140514154130.10746.1412.stgit@bahia.local> <20140514154137.10746.94708.stgit@bahia.local> <20140515060425.GA31192@grmbl.mre> <20140515062351.GB14456@redhat.com> <20140515064635.GB31192@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140515064635.GB31192@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Kevin Wolf , Fam Zheng , Anthony Liguori , Juan Quintela , Alexander Graf , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Greg Kurz On Thu, May 15, 2014 at 12:16:35PM +0530, Amit Shah wrote: > On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > > There is a need to add some more fields to VirtIODevice that should be > > > > migrated (broken status, endianness). The problem is that we do not > > > > want to break compatibility while adding a new feature... This issue has > > > > been addressed in the generic VMState code with the use of optional > > > > subsections. As a *temporary* alternative to port the whole virtio > > > > migration code to VMState, this patch mimics a similar subsectionning > > > > ability for virtio. > > BTW Greg, do you plan on working on vmstate for virtio? > > > > > Since each virtio device is streamed in its own section, the idea is to > > > > stream subsections between the end of the device section and the start > > > > of the next sections. This allows an older QEMU to complain and exit > > > > when fed with subsections: > > > > > > > > Unknown savevm section type 5 > > > > Error -22 while loading VM state > > > > > > Please make this configurable -- either via configure or device > > > properties. That avoids having to break existing configurations that > > > work without this patch. > > > > > > > All users of virtio_load()/virtio_save() need to be patched because the > > > > subsections are streamed AFTER the device itself. > > > > > > Since all have the same fixup, I'm wondering if a new section can be > > > added to the virtio-bus itself, which gets propagated to all devices > > > upon load in the dest. > > > > This calls for a way for devices to inherit properties from the bus, > > which doesn't exist ATM. > > Fine but let's not hold up this patchset because of this. > > No, only suggestion is to add a migration section in the bus, and then > it's easier to do this in the post-migrate functions for each device > -- so only one new section gets introduced instead of all devices > being modified to send a new subsection. > > Amit I don't mind but the gain isn't very big here. -- MST