From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkqAn-0004dh-FI for qemu-devel@nongnu.org; Thu, 15 May 2014 03:33:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkqAh-0007a9-7P for qemu-devel@nongnu.org; Thu, 15 May 2014 03:33:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkqAg-0007a2-W5 for qemu-devel@nongnu.org; Thu, 15 May 2014 03:33:43 -0400 Date: Thu, 15 May 2014 09:33:38 +0200 From: Stefan Hajnoczi Message-ID: <20140515073338.GA1111@stefanha-thinkpad.redhat.com> References: <1399559698-31900-1-git-send-email-stefanha@redhat.com> <1399559698-31900-22-git-send-email-stefanha@redhat.com> <20140515013420.GE19672@T430.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140515013420.GE19672@T430.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_aio_context() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, Christian Borntraeger On Thu, May 15, 2014 at 09:34:20AM +0800, Fam Zheng wrote: > On Thu, 05/08 16:34, Stefan Hajnoczi wrote: > > Implement .bdrv_detach/attach_aio_context() interfaces to propagate > > detach/attach to BDRVVmdkState->extents[].file. The block layer takes > > care of ->file and ->backing_hd but doesn't know about our extents > > BlockDriverStates, which is also part of the graph. > > > > Reviewed-by: Fam Zheng > > Signed-off-by: Stefan Hajnoczi > > --- > > Noticed this doesn't apply any more due to recent VMDK fixes, because the > context is different. Trivial to fix, though. Yep, me too. The resolution is trivial though. Stefan