From: Kevin Wolf <kwolf@redhat.com>
To: Mike Day <ncmike@ncultra.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot
Date: Thu, 15 May 2014 15:26:12 +0200 [thread overview]
Message-ID: <20140515132612.GG3822@noname.redhat.com> (raw)
In-Reply-To: <CAGaKXu0YLRODMaF_vt6o=Mr0A+mD7kJ4ydvQ8No-VE8p7vZ0UA@mail.gmail.com>
Am 15.05.2014 um 15:07 hat Mike Day geschrieben:
> On Wed, May 14, 2014 at 11:15 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> >> freeing the extra clusters.
> >
> > Do you have an easy reproducer? Because I can't see the bug.
>
> Thanks for the review! I was having a hard time reproducing this until
> I did a bisect. This bug was fixed by 65f33bc which was merged at or
> after the time I submitted the patch:
>
> qcow2: Fix alloc_clusters_noref() overflow detection
>
> I can reproduce the bug by checking out the immediate ancestor
> 43cbeffb1, creating a single snapshot in a qcow2 image, and then
> attempting to delete that snapshot.
>
> The error I get is:
> qemu-img: Could not delete snapshot 'snapone': (Failed to remove
> snapshot from snapshot list: File too large)
>
> This is the error that is fixed by 65f33bc
Yes, that makes sense. Thanks Mike. I think we can disregard your patch
then and consider the problem fixed.
Kevin
next prev parent reply other threads:[~2014-05-15 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 20:27 [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot Mike Day
2014-05-14 15:15 ` Kevin Wolf
2014-05-15 13:07 ` Mike Day
2014-05-15 13:26 ` Kevin Wolf [this message]
2014-05-14 23:54 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515132612.GG3822@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=ncmike@ncultra.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).