From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Wkvfy-0001Md-HJ
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:26:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Wkvfs-0000FI-DI
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:26:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32302)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Wkvfs-0000FE-52
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:26:16 -0400
Date: Thu, 15 May 2014 15:26:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140515132612.GG3822@noname.redhat.com>
References: <1399926438-32292-1-git-send-email-ncmike@ncultra.org>
	<20140514151555.GO3610@noname.redhat.com>
	<CAGaKXu0YLRODMaF_vt6o=Mr0A+mD7kJ4ydvQ8No-VE8p7vZ0UA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGaKXu0YLRODMaF_vt6o=Mr0A+mD7kJ4ydvQ8No-VE8p7vZ0UA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mike Day <ncmike@ncultra.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 15.05.2014 um 15:07 hat Mike Day geschrieben:
> On Wed, May 14, 2014 at 11:15 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> >> freeing the extra clusters.
> >
> > Do you have an easy reproducer? Because I can't see the bug.
> 
> Thanks for the review! I was having a hard time reproducing this until
> I did a bisect. This bug was fixed by 65f33bc which was merged at or
> after  the time I submitted the patch:
> 
>  qcow2: Fix alloc_clusters_noref() overflow detection
> 
> I can reproduce the bug by checking out the immediate ancestor
> 43cbeffb1, creating a single snapshot in a qcow2 image, and then
> attempting to delete that snapshot.
> 
> The error I get is:
> qemu-img: Could not delete snapshot 'snapone': (Failed to remove
> snapshot from snapshot list: File too large)
> 
> This is the error that is fixed by 65f33bc

Yes, that makes sense. Thanks Mike. I think we can disregard your patch
then and consider the problem fixed.

Kevin