From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl07t-0003Pa-5W for qemu-devel@nongnu.org; Thu, 15 May 2014 14:11:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl07o-0002pv-5m for qemu-devel@nongnu.org; Thu, 15 May 2014 14:11:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl07n-0002pe-VO for qemu-devel@nongnu.org; Thu, 15 May 2014 14:11:24 -0400 Date: Thu, 15 May 2014 14:11:17 -0400 From: Luiz Capitulino Message-ID: <20140515141117.1256876c@redhat.com> In-Reply-To: <1399449234-28501-1-git-send-email-armbru@redhat.com> References: <1399449234-28501-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 00/12] qapi: Purge error_is_set() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, akong@redhat.com, vilanova@ac.upc.edu On Wed, 7 May 2014 09:53:42 +0200 Markus Armbruster wrote: > This is the sixth part, covering QAPI and its users. Luiz agreed to > take this through his tree. >=20 > PATCH 01-08 are preparatory cleanups. >=20 > PATCH 09-11 fix misuses of the visitor API in hand-written code. > Generated code uses the API correctly. >=20 > PATCH 12 converts QAPI and its users to the common use of the error > API, purging error_is_set() along the way. >=20 > v1 has a PATCH 13 that drops error_is_set(). This depends on all five > prior parts of the purge, of which only the first two have been > committed already. Luiz asked me to drop it from this series. >=20 > My series conflicts with Llu=C3=ADs's "qapi: Allow modularization of QAPI > schema files" and Amos's "qapi: fix coding style in generated code", > but the conflicts are trivial, and 3-way merge can take care of them. >=20 > v2: > * Fix pasto in commit messages of PATCH 10+11 [Eric] > * Fix logic error in PATCH 12 [Eric] > * Update copyright notice in PATCH 12 > * Unbundle PATCH 13 Applied to the qmp branch, thanks. >=20 > Markus Armbruster (12): > qapi: Update qapi-code-gen.txt example to match current code > qapi: Normalize marshalling's visitor initialization and cleanup > qapi: Remove unused Visitor callbacks start_handle(), end_handle() > qapi: Replace start_optional()/end_optional() by optional() > qapi-visit.py: Clean up confusing push_indent() / pop_indent() use > qapi: Clean up shadowing of parameters and locals in inner scopes > qapi-visit.py: Clean up a sloppy use of field prefix > qapi: Un-inline visit of implicit struct > hmp: Call visit_end_struct() after visit_start_struct() succeeds > hw: Don't call visit_end_struct() after visit_start_struct() fails > tests: Don't call visit_end_struct() after visit_start_struct() fails > qapi: Replace uncommon use of the error API by the common one >=20 > docs/qapi-code-gen.txt | 165 ++++++++++++++--------- > hmp.c | 16 +-- > hw/timer/mc146818rtc.c | 41 +++++- > hw/virtio/virtio-balloon.c | 33 +++-- > include/qapi/visitor-impl.h | 8 +- > include/qapi/visitor.h | 5 +- > qapi/opts-visitor.c | 5 +- > qapi/qapi-visit-core.c | 259 +++++++++++++++----------------= ------ > qapi/qmp-input-visitor.c | 6 +- > qapi/string-input-visitor.c | 6 +- > scripts/qapi-commands.py | 89 ++++++++----- > scripts/qapi-visit.py | 232 +++++++++++++++++++------------= -- > tests/test-qmp-input-strict.c | 28 +++- > tests/test-qmp-input-visitor.c | 26 ++-- > tests/test-qmp-output-visitor.c | 28 +++- > tests/test-visitor-serialization.c | 26 +++- > 16 files changed, 558 insertions(+), 415 deletions(-) >=20