From: Igor Mammedov <imammedo@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] apci: fix ACPI tables for -no-hpet option
Date: Thu, 15 May 2014 14:45:34 +0200 [thread overview]
Message-ID: <20140515144534.0c8e8d87@nial.usersys.redhat.com> (raw)
In-Reply-To: <1399553920-3358-1-git-send-email-marcel.a@redhat.com>
On Thu, 8 May 2014 15:58:40 +0300
Marcel Apfelbaum <marcel.a@redhat.com> wrote:
> A wrong offset was added to the tables pointed by RSDT
> if the HPET table is not present.
>
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index c98df88..d65fab0 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1417,8 +1417,8 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables)
> acpi_add_table(table_offsets, tables->table_data);
>
> build_madt(tables->table_data, tables->linker, &cpu, guest_info);
> - acpi_add_table(table_offsets, tables->table_data);
> if (misc.has_hpet) {
> + acpi_add_table(table_offsets, tables->table_data);
> build_hpet(tables->table_data, tables->linker);
> }
> if (guest_info->numa_nodes) {
Reviewed-By: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2014-05-15 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 12:58 [Qemu-devel] [PATCH] apci: fix ACPI tables for -no-hpet option Marcel Apfelbaum
2014-05-15 12:45 ` Igor Mammedov [this message]
2014-05-15 12:51 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515144534.0c8e8d87@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=aliguori@amazon.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).