From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Wkv2g-0002Og-3X
	for qemu-devel@nongnu.org; Thu, 15 May 2014 08:45:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Wkv2Z-0001tv-P3
	for qemu-devel@nongnu.org; Thu, 15 May 2014 08:45:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Wkv2Z-0001tl-GQ
	for qemu-devel@nongnu.org; Thu, 15 May 2014 08:45:39 -0400
Date: Thu, 15 May 2014 14:45:34 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140515144534.0c8e8d87@nial.usersys.redhat.com>
In-Reply-To: <1399553920-3358-1-git-send-email-marcel.a@redhat.com>
References: <1399553920-3358-1-git-send-email-marcel.a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] apci: fix ACPI tables for -no-hpet option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com, mst@redhat.com

On Thu,  8 May 2014 15:58:40 +0300
Marcel Apfelbaum <marcel.a@redhat.com> wrote:

> A wrong offset was added to the tables pointed by RSDT
> if the HPET table is not present.
> 
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  hw/i386/acpi-build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index c98df88..d65fab0 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1417,8 +1417,8 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables)
>      acpi_add_table(table_offsets, tables->table_data);
>  
>      build_madt(tables->table_data, tables->linker, &cpu, guest_info);
> -    acpi_add_table(table_offsets, tables->table_data);
>      if (misc.has_hpet) {
> +        acpi_add_table(table_offsets, tables->table_data);
>          build_hpet(tables->table_data, tables->linker);
>      }
>      if (guest_info->numa_nodes) {

Reviewed-By: Igor Mammedov <imammedo@redhat.com>