From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Wl1sJ-0002fa-S8
	for qemu-devel@nongnu.org; Thu, 15 May 2014 16:03:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Wl1sF-0001Gi-8e
	for qemu-devel@nongnu.org; Thu, 15 May 2014 16:03:31 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:39599 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Wl1sF-0001GT-2U
	for qemu-devel@nongnu.org; Thu, 15 May 2014 16:03:27 -0400
Date: Thu, 15 May 2014 22:03:59 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140515200358.GA15470@irqsave.net>
References: <1400076469-5914-1-git-send-email-benoit.canet@irqsave.net>
	<1400076469-5914-2-git-send-email-benoit.canet@irqsave.net>
	<20140515151337.735d886d@redhat.com> <537517D6.2070601@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <537517D6.2070601@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, armbru@redhat.com, vilanova@ac.upc.edu, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

The Thursday 15 May 2014 =E0 13:39:02 (-0600), Eric Blake wrote :
> On 05/15/2014 01:13 PM, Luiz Capitulino wrote:
> > On Wed, 14 May 2014 16:07:49 +0200
> > Beno=EEt Canet <benoit.canet@irqsave.net> wrote:
> >=20
> >> The purpose of this change is to help create a json file containing
> >> common definitions; each bit of generated C code must be emitted
> >> only one time.
> >>
> >> A second history global to all QAPISchema instances has been added
> >> to detect when a file is included more than one time and skip these
> >> includes.
> >> It does not act as a stack and the changes made to it by the
> >> __init__ function are propagated back to the caller so it's really
> >> a global state.
> >=20
> > Shouldn't this behavior be noted somewhere? Eg. in writing-qmp-comman=
ds.txt
> > or qapi-code-gen.txt?
>=20
> dosc/qapi-code-gen.txt already covers the {'include':'file'} syntax, so
> yes, that should be updated to mention that multiple includes of the
> same file are now safe.

ok, I will do this.

Best regards

Beno=EEt
>=20
> --=20
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20