From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WlD9w-0002M1-VE
	for qemu-devel@nongnu.org; Fri, 16 May 2014 04:06:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WlD9o-0004d8-6y
	for qemu-devel@nongnu.org; Fri, 16 May 2014 04:06:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15640)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WlD9n-0004cq-RU
	for qemu-devel@nongnu.org; Fri, 16 May 2014 04:06:20 -0400
Date: Fri, 16 May 2014 16:06:27 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140516080627.GF1941@T430.nay.redhat.com>
References: <1400192774-606-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1400192774-606-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] iotests: Allow out-of-tree run
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>

On Fri, 05/16 00:26, Max Reitz wrote:
> This series enables qemu-iotests to be run in a build tree outside of
> the source tree.

Yes, I've always used the long command to run iotests, namely,

$ (cd $SRC_PATH/tests/qemu-iotests; TEST_DIR=/tmp/qemu-iotests QEMU_PROG=~/build/last/x86_64-softmmu/qemu-system-x86_64 QEMU_IMG_PROG=~/build/last/qemu-img QEMU_IO_PROG=~/build/last/qemu-io QEMU_NBD_PROG=~/build/last/qemu-nbd ./check -qcow2 -o "" )

and I hated that. It'd be a great improvement to allow iotests to find the
built binaries by itself.

Thanks for working on this!

Fam

> 
> 
> Max Reitz (7):
>   iotests: Allow out-of-tree run
>   configure: Enable out-of-tree iotests
>   iotests: Add default common.env
>   iotests: Source common.env
>   iotests: Use $PYTHON for Python scripts
>   iotests: Drop Python version from 065's Shebang
>   iotests: Fix 083 for out-of-tree builds
> 
>  configure                             |  12 ++++
>  tests/qemu-iotests/031                |   8 +--
>  tests/qemu-iotests/036                |   6 +-
>  tests/qemu-iotests/039                |  18 +++---
>  tests/qemu-iotests/054                |   2 +-
>  tests/qemu-iotests/060                |  20 +++----
>  tests/qemu-iotests/061                |  24 ++++----
>  tests/qemu-iotests/065                |   2 +-
>  tests/qemu-iotests/083                |  10 ++--
>  tests/qemu-iotests/check              | 102 ++++++++++++++++++++++++++++++----
>  tests/qemu-iotests/common             |   8 +--
>  tests/qemu-iotests/common.config      |   2 +-
>  tests/qemu-iotests/common.env.default |   6 ++
>  tests/qemu-iotests/common.rc          |   8 +--
>  tests/qemu-iotests/iotests.py         |   3 +-
>  15 files changed, 165 insertions(+), 66 deletions(-)
>  create mode 100644 tests/qemu-iotests/common.env.default
> 
> -- 
> 1.9.2
> 
>