From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlEc9-0004Mu-6l for qemu-devel@nongnu.org; Fri, 16 May 2014 05:39:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlEc3-0001ns-1o for qemu-devel@nongnu.org; Fri, 16 May 2014 05:39:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlEc2-0001nj-Qx for qemu-devel@nongnu.org; Fri, 16 May 2014 05:39:34 -0400 Date: Fri, 16 May 2014 11:39:27 +0200 From: Kevin Wolf Message-ID: <20140516093927.GC4508@noname.redhat.com> References: <5374E445.9070609@redhat.com> <20140515184103.GM8452@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140515184103.GM8452@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 15.05.2014 um 20:41 hat Jeff Cody geschrieben: > The only thing I don't like about moving this further back in the > patch series is it makes the earlier patches untestable; I can't > easily test the usage of the node-names for various intermediate BDS > because they don't have node-names set. So that means I'll just need > to rebase the patches prior to sending. I don't quite follow. Can't you always manually assign node-names? This is how libvirt is supposed to use the interface. I'm not totally sure whether automatically generated node-names are a good idea, but I can see how they are useful with human monitor users which may not specify a node-name everywhere (I've used device_add without an ID often enough, only to find that I can't remove the device any more). We should just make sure that they are really only used by human users. Kevin