From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJRw-0004jk-F5 for qemu-devel@nongnu.org; Fri, 16 May 2014 10:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlJRn-0006Wv-Dw for qemu-devel@nongnu.org; Fri, 16 May 2014 10:49:28 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:47326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJRn-0006Wd-2u for qemu-devel@nongnu.org; Fri, 16 May 2014 10:49:19 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 May 2014 15:49:17 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 127822190046 for ; Fri, 16 May 2014 15:49:06 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4GEnE3t29098208 for ; Fri, 16 May 2014 14:49:15 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4GEnDOS031702 for ; Fri, 16 May 2014 08:49:14 -0600 Date: Fri, 16 May 2014 16:49:11 +0200 From: Michael Mueller Message-ID: <20140516164911.1e62c844@bee> In-Reply-To: <5375F739.2090903@de.ibm.com> References: <1399993114-15333-1-git-send-email-mimu@linux.vnet.ibm.com> <5375F739.2090903@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 RFC 0/6] KVM: s390: cpu model implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov , linux-kernel@vger.kernel.org, Alexander Graf , qemu-devel@nongnu.org, "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson On Fri, 16 May 2014 13:32:09 +0200 Christian Borntraeger wrote: > On 13/05/14 16:58, Michael Mueller wrote: > > The proposed patch set implements S390 cpu model support in kvm. A cpu > > model is defined by a triple comprizing the cpu type , the cpu facility > > set and instruction blocking control. A consumer requests a feasible > > combination of that that triple before vcpu creation. All subsequently > > created vcpu's will use this cpu configuration. > > > > Michael Mueller (6): > > s390/sclp: add sclp_get_ibc function > > KVM: s390: split SIE state guest prefix field > > KVM: s390: use facilities and cpu_id per KVM > > KVM: s390: add ibc api > > KVM: s390: initial implementation of soft facilities > > KVM: s390: add cpu model support > > > > arch/s390/include/asm/kvm_host.h | 13 +- > > arch/s390/include/asm/sclp.h | 1 + > > arch/s390/include/uapi/asm/kvm.h | 23 ++++ > > arch/s390/kvm/Makefile | 2 +- > > arch/s390/kvm/diag.c | 2 +- > > arch/s390/kvm/gaccess.c | 4 +- > > arch/s390/kvm/gaccess.h | 8 +- > > arch/s390/kvm/ibc.c | 29 +++++ > > arch/s390/kvm/kvm-s390.c | 263 +++++++++++++++++++++++++++++++++------ > > arch/s390/kvm/kvm-s390.h | 43 ++++++- > > arch/s390/kvm/priv.c | 16 ++- > > arch/s390/kvm/softfac.c | 38 ++++++ > > drivers/s390/char/sclp_early.c | 12 +- > > 13 files changed, 397 insertions(+), 57 deletions(-) > > create mode 100644 arch/s390/kvm/ibc.c > > create mode 100644 arch/s390/kvm/softfac.c > > > > I will add patch 1 and 2 to the next KVM: s390: pull request as there > does not seem to be potential for discussion / interface changes. > Everything else looks ok, but I want to wait if additional feedback > about the overall design comes in. Perfect... > > Christian