From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward
Date: Sun, 18 May 2014 10:20:52 -0300 [thread overview]
Message-ID: <20140518132052.GA22484@amt.cnet> (raw)
In-Reply-To: <1400253321-9239-1-git-send-email-agraf@suse.de>
On Fri, May 16, 2014 at 05:15:21PM +0200, Alexander Graf wrote:
> When we migrate we ask the kernel about its current belief on what the guest
> time would be. However, I've seen cases where the kvmclock guest structure
> indicates a time more recent than the kvm returned time.
>
> To make sure we never go backwards, calculate what the guest would have seen
> as time at the point of migration and use that value instead of the kernel
> returned one when it's more recent.
>
> While the underlying bug is supposedly fixed on newer KVM versions, it doesn't
> hurt to base the view of the kvmclock after migration on the same foundation
> in host as well as guest.
Remove this last phrase from the changelog please, the underlying bug is
not fixed on newer KVM versions.
Otherwise
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
next prev parent reply other threads:[~2014-05-18 13:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:15 [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward Alexander Graf
2014-05-18 13:20 ` Marcelo Tosatti [this message]
2014-05-19 11:31 ` Paolo Bonzini
2014-05-21 10:03 ` Alexander Graf
2014-06-02 20:31 ` Marcin Gibuła
2014-06-03 5:16 ` Marcelo Tosatti
2014-06-03 9:11 ` Marcin Gibuła
2014-06-03 11:13 ` Paolo Bonzini
2014-06-03 16:34 ` [Qemu-devel] [PATCH uq/master] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation Marcelo Tosatti
2014-07-15 19:45 ` Paolo Bonzini
2014-07-15 20:03 ` Marcin Gibuła
2014-07-15 20:15 ` Paolo Bonzini
2014-07-15 20:31 ` Marcelo Tosatti
2014-07-15 20:34 ` Marcelo Tosatti
2014-07-15 20:43 ` Paolo Bonzini
2014-07-15 21:05 ` Andrey Korolyov
2014-07-15 21:08 ` Paolo Bonzini
2014-07-15 20:43 ` Paolo Bonzini
2014-07-15 19:44 ` [Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140518132052.GA22484@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).