From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WmMx3-0002oE-Oh
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:46:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WmMwv-00013e-UC
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:45:57 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:40273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WmMwv-000127-K8
	for qemu-devel@nongnu.org; Mon, 19 May 2014 08:45:49 -0400
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Mon, 19 May 2014 13:45:46 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 982FB2190068
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 13:45:33 +0100 (BST)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s4JCjgBM1376766
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 12:45:42 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s4JDjgmu017243
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 07:45:43 -0600
Date: Mon, 19 May 2014 14:45:38 +0200
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20140519144538.0e52b7d2@bahia.local>
In-Reply-To: <5379F2DF.2040909@suse.de>
References: <20140519063132.22955.63563.stgit@bahia.local>
	<5379F2DF.2040909@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Mon, 19 May 2014 14:02:39 +0200
Alexander Graf <agraf@suse.de> wrote:

> 
> On 19.05.14 10:38, Greg Kurz wrote:
> > Hi,
> >
> > This patch set tries to address comments from the initial
> > review. For this round, I have focused on two changes:
> > - as suggested by Andreas, we now call the device specific
> >    code from the generic code to ease the implementation of
> >    future devices. This is achieved with the addition of
> >    load/save methods to VirtioDeviceClass.
> > - virtio subsections now implement a "needed" concept with
> >    the same semantics as in the VMState code.
> >
> > I haven't looked at compat mode issues yet, but it is
> > on my TODO list.
> 
> If you fix up the comments to be either
> 
>    /*
>     * foo
>     */
> 
> or
> 
>    /* foo */
> 
> style, not
> 
>    /* foo
>     */
> 
> then you get my
> 
> 
> Acked-by: Alexander Graf <agraf@suse.de>
> 
> 
> Alex
> 

I'll certainly do that then ! :)

BTW, the faulty comments are in patch 8/8 that I was
sending for informational purpose only as it is part
of the bi-endian virtio serie. Should I merge the
two patch sets at some point ?

-- 
Gregory Kurz                                     kurzgreg@fr.ibm.com
                                                 gkurz@linux.vnet.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.