From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38094)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WmPDq-0005no-Ei
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:11:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WmPDk-0006ID-Mh
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:11:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8396)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WmPDk-0006Hw-GP
	for qemu-devel@nongnu.org; Mon, 19 May 2014 11:11:20 -0400
Date: Mon, 19 May 2014 18:10:08 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140519151008.GA22363@redhat.com>
References: <20140519063132.22955.63563.stgit@bahia.local>
	<5379F2DF.2040909@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5379F2DF.2040909@suse.de>
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Greg Kurz <gkurz@linux.vnet.ibm.com>

On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
> 
> On 19.05.14 10:38, Greg Kurz wrote:
> >Hi,
> >
> >This patch set tries to address comments from the initial
> >review. For this round, I have focused on two changes:
> >- as suggested by Andreas, we now call the device specific
> >   code from the generic code to ease the implementation of
> >   future devices. This is achieved with the addition of
> >   load/save methods to VirtioDeviceClass.
> >- virtio subsections now implement a "needed" concept with
> >   the same semantics as in the VMState code.
> >
> >I haven't looked at compat mode issues yet, but it is
> >on my TODO list.
> 
> If you fix up the comments to be either
> 
>   /*
>    * foo
>    */
> 
> or
> 
>   /* foo */
> 
> style, not
> 
>   /* foo
>    */
> 
> then you get my
> 
> 
> Acked-by: Alexander Graf <agraf@suse.de>
> 
> 
> Alex

Documented anywhere?
Linux style is

        /* Always
         * like this.
         */

so it's definitely not universal.


-- 
MST