From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPrJ-00041b-8I for qemu-devel@nongnu.org; Mon, 19 May 2014 11:52:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmPrC-000402-1O for qemu-devel@nongnu.org; Mon, 19 May 2014 11:52:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmPrB-0003zr-PJ for qemu-devel@nongnu.org; Mon, 19 May 2014 11:52:05 -0400 Date: Mon, 19 May 2014 18:50:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20140519155053.GA31595@redhat.com> References: <20140519063132.22955.63563.stgit@bahia.local> <5379F2DF.2040909@suse.de> <20140519151008.GA22363@redhat.com> <537A2506.9070307@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <537A2506.9070307@suse.de> Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Kevin Wolf , Fam Zheng , Anthony Liguori , Juan Quintela , qemu-devel@nongnu.org, Stefan Hajnoczi , Amit Shah , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Greg Kurz On Mon, May 19, 2014 at 05:36:38PM +0200, Alexander Graf wrote: > > On 19.05.14 17:10, Michael S. Tsirkin wrote: > >On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote: > >>On 19.05.14 10:38, Greg Kurz wrote: > >>>Hi, > >>> > >>>This patch set tries to address comments from the initial > >>>review. For this round, I have focused on two changes: > >>>- as suggested by Andreas, we now call the device specific > >>> code from the generic code to ease the implementation of > >>> future devices. This is achieved with the addition of > >>> load/save methods to VirtioDeviceClass. > >>>- virtio subsections now implement a "needed" concept with > >>> the same semantics as in the VMState code. > >>> > >>>I haven't looked at compat mode issues yet, but it is > >>>on my TODO list. > >>If you fix up the comments to be either > >> > >> /* > >> * foo > >> */ > >> > >>or > >> > >> /* foo */ > >> > >>style, not > >> > >> /* foo > >> */ > >> > >>then you get my > >> > >> > >>Acked-by: Alexander Graf > >> > >> > >>Alex > >Documented anywhere? > > Impressive. I thought it was, but apparently I'm wrong :). Nevermind then. > > >Linux style is > > > > /* Always > > * like this. > > */ > > > >so it's definitely not universal. > > Eh - documented anywhere? Linux usually goes with C style comments. > > > Alex Actually, what I said is only true for networking, I'm just hacking in that field recently. It's all in Documentation/CodingStyle: The preferred style for long (multi-line) comments is: /* * This is the preferred style for multi-line * comments in the Linux kernel source code. * Please use it consistently. * * Description: A column of asterisks on the left side, * with beginning and ending almost-blank lines. */ For files in net/ and drivers/net/ the preferred style for long (multi-line) comments is a little different. /* The preferred comment style for files in net/ and drivers/net * looks like this. * * It is nearly the same as the generally preferred comment style, * but there is no initial almost-blank line. */