From: Leandro Dorileo <l@dorileo.org>
To: Chun Yan Liu <cyliu@suse.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V26 00/32] replace QEMUOptionParameter with QemuOpts
Date: Mon, 19 May 2014 18:11:22 -0300 [thread overview]
Message-ID: <20140519211122.GA2051@dorilex-lnv.MultilaserAP> (raw)
In-Reply-To: <5379E4D5020000660002B7B8@soto.provo.novell.com>
On Sun, May 18, 2014 at 09:02:45PM -0600, Chun Yan Liu wrote:
>
>
> >>> On 5/6/2014 at 09:26 PM, in message
> <20140506132615.GV15810@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi
> <stefanha@gmail.com> wrote:
> > On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote:
> > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that
> > only
> > > one Qemu Option structure is kept in QEMU code.
> > >
> > > ---
> > > Changes to v25:
> > > * split v25 2/31 (add def_value_str to QemuOptDesc) into two patches:
> > > 1st patch adds def_value_str, 2nd patch repurpose qemu_opts_print.
> > > * update 4/32 qapi command line description.
> > > * update 12/32 (change block layer to support both) according to
> > > Eric's comments.
> > > * small update to gluster.c
> > > * rebase to latest code
> > >
> > > All patches are also available from:
> > > https://github.com/chunyanliu/qemu/commits/QemuOpts
> >
> > I looked through the comments from Leandro and Eric. A respin is
> > necessary to address the test failures that Leandro found. Please also
> > address the comments Eric made.
> >
> > We're almost there now!
> >
> >
>
> Hi, Stefan, Leandro & Eric,
>
> Could you help to have a look at the new update? I've sent it about 10
> days ago. It addressed all Eric's comments in last version and two
> memory free fix to address iotest issue. Hope it's the final work and
> won't take you more time :-)
>
> The thread has been cut into two, since the git-send-email died in the
> middle at the 1st time sending. Please refer to:
I'll take a look at it, thanks.
--
Leandro Dorileo
next prev parent reply other threads:[~2014-05-19 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398762656-26079-1-git-send-email-cyliu@suse.com>
[not found] ` <1398762656-26079-14-git-send-email-cyliu@suse.com>
2014-05-01 19:18 ` [Qemu-devel] [PATCH V26 13/32] vvfat.c: handle cross_driver's create_options and create_opts Eric Blake
2014-05-01 19:22 ` Eric Blake
[not found] ` <1398762656-26079-16-git-send-email-cyliu@suse.com>
2014-05-01 19:25 ` [Qemu-devel] [PATCH V26 15/32] gluster.c: replace QEMUOptionParameter with QemuOpts Eric Blake
2014-05-06 13:18 ` Stefan Hajnoczi
[not found] ` <1398762656-26079-20-git-send-email-cyliu@suse.com>
2014-05-01 21:50 ` [Qemu-devel] [PATCH V26 19/32] qcow2.c: " Eric Blake
[not found] ` <1398762656-26079-13-git-send-email-cyliu@suse.com>
2014-05-01 22:14 ` [Qemu-devel] [PATCH V26 12/32] change block layer to support both QemuOpts and QEMUOptionParamter Leandro Dorileo
[not found] ` <5360587E.5050409@redhat.com>
2014-05-04 3:51 ` Chun Yan Liu
[not found] ` <1398762656-26079-3-git-send-email-cyliu@suse.com>
2014-05-06 13:14 ` [Qemu-devel] [PATCH V26 02/32] QemuOpts: add def_value_str to QemuOptDesc Stefan Hajnoczi
[not found] ` <1398762656-26079-4-git-send-email-cyliu@suse.com>
[not found] ` <535FD3B6.6020701@redhat.com>
2014-05-04 3:20 ` [Qemu-devel] [PATCH V26 03/32] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Chun Yan Liu
2014-05-06 13:14 ` Stefan Hajnoczi
[not found] ` <1398762656-26079-5-git-send-email-cyliu@suse.com>
2014-05-06 13:15 ` [Qemu-devel] [PATCH V26 04/32] qapi: output def_value_str when query command line options Stefan Hajnoczi
[not found] ` <1398762656-26079-18-git-send-email-cyliu@suse.com>
2014-05-01 21:57 ` [Qemu-devel] [PATCH V26 17/32] nfs.c: replace QEMUOptionParameter with QemuOpts Eric Blake
2014-05-06 13:20 ` Stefan Hajnoczi
[not found] ` <1398762656-26079-21-git-send-email-cyliu@suse.com>
2014-05-05 23:08 ` [Qemu-devel] [PATCH V26 20/32] qed.c: " Eric Blake
2014-05-06 13:22 ` Stefan Hajnoczi
[not found] ` <1398762656-26079-28-git-send-email-cyliu@suse.com>
2014-05-06 13:24 ` [Qemu-devel] [PATCH V26 27/32] vdi.c: " Stefan Hajnoczi
2014-05-06 13:26 ` [Qemu-devel] [PATCH V26 00/32] " Stefan Hajnoczi
2014-05-19 3:02 ` Chun Yan Liu
2014-05-19 21:11 ` Leandro Dorileo [this message]
2014-06-03 5:34 ` Chun Yan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519211122.GA2051@dorilex-lnv.MultilaserAP \
--to=l@dorileo.org \
--cc=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).