From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmUq3-0003Kp-Ku for qemu-devel@nongnu.org; Mon, 19 May 2014 17:11:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmUpx-0006MH-NS for qemu-devel@nongnu.org; Mon, 19 May 2014 17:11:15 -0400 Received: from mail-yh0-f49.google.com ([209.85.213.49]:42867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmUpx-0006LT-Ik for qemu-devel@nongnu.org; Mon, 19 May 2014 17:11:09 -0400 Received: by mail-yh0-f49.google.com with SMTP id c41so7347698yho.36 for ; Mon, 19 May 2014 14:11:08 -0700 (PDT) Date: Mon, 19 May 2014 18:11:22 -0300 From: Leandro Dorileo Message-ID: <20140519211122.GA2051@dorilex-lnv.MultilaserAP> References: <1398762656-26079-1-git-send-email-cyliu@suse.com> <20140506132615.GV15810@stefanha-thinkpad.redhat.com> <5379E4D5020000660002B7B8@soto.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5379E4D5020000660002B7B8@soto.provo.novell.com> Subject: Re: [Qemu-devel] [PATCH V26 00/32] replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chun Yan Liu Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On Sun, May 18, 2014 at 09:02:45PM -0600, Chun Yan Liu wrote: > > > >>> On 5/6/2014 at 09:26 PM, in message > <20140506132615.GV15810@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi > wrote: > > On Tue, Apr 29, 2014 at 05:10:24PM +0800, Chunyan Liu wrote: > > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > > only > > > one Qemu Option structure is kept in QEMU code. > > > > > > --- > > > Changes to v25: > > > * split v25 2/31 (add def_value_str to QemuOptDesc) into two patches: > > > 1st patch adds def_value_str, 2nd patch repurpose qemu_opts_print. > > > * update 4/32 qapi command line description. > > > * update 12/32 (change block layer to support both) according to > > > Eric's comments. > > > * small update to gluster.c > > > * rebase to latest code > > > > > > All patches are also available from: > > > https://github.com/chunyanliu/qemu/commits/QemuOpts > > > > I looked through the comments from Leandro and Eric. A respin is > > necessary to address the test failures that Leandro found. Please also > > address the comments Eric made. > > > > We're almost there now! > > > > > > Hi, Stefan, Leandro & Eric, > > Could you help to have a look at the new update? I've sent it about 10 > days ago. It addressed all Eric's comments in last version and two > memory free fix to address iotest issue. Hope it's the final work and > won't take you more time :-) > > The thread has been cut into two, since the git-send-email died in the > middle at the 1st time sending. Please refer to: I'll take a look at it, thanks. -- Leandro Dorileo