qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091
Date: Tue, 20 May 2014 09:03:11 +0800	[thread overview]
Message-ID: <20140520010311.GA7688@T430.nay.redhat.com> (raw)
In-Reply-To: <20140519144029.GD4060@noname.redhat.com>

On Mon, 05/19 16:40, Kevin Wolf wrote:
> Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben:
> > We should allow testing this on tmpfs. Any cache setting in iotests
> > should try to obey $CACHEMODE.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> Should we set _default_cache_mode=none then at least?

Yes we should set a default. We use _default_cache_mode=writethrough elsewhere,
why use none over writethrough here?

>                                                       We should probably
> also refuse to run with unsafe.

OK, I'll add _supported_cache_modes.

Fam

> >  tests/qemu-iotests/091 | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
> > index 384b3ac..a7deea8 100755
> > --- a/tests/qemu-iotests/091
> > +++ b/tests/qemu-iotests/091
> > @@ -59,13 +59,13 @@ echo === Starting QEMU VM1 ===
> >  echo
> >  
> >  qemu_comm_method="monitor"
> > -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk
> > +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk
> >  h1=$QEMU_HANDLE
> >  
> >  echo
> >  echo === Starting QEMU VM2 ===
> >  echo
> > -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk \
> > +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk \
> >               -incoming "exec: cat '${MIG_FIFO}'"
> >  h2=$QEMU_HANDLE
> >  
> > -- 
> > 1.9.2
> > 

  reply	other threads:[~2014-05-20  1:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 12:24 [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091 Fam Zheng
2014-05-19 14:40 ` Kevin Wolf
2014-05-20  1:03   ` Fam Zheng [this message]
2014-05-20  8:52     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520010311.GA7688@T430.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).