From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WmYST-00064x-Ho
	for qemu-devel@nongnu.org; Mon, 19 May 2014 21:03:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WmYSN-0000aw-Dp
	for qemu-devel@nongnu.org; Mon, 19 May 2014 21:03:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15560)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WmYSN-0000aV-6N
	for qemu-devel@nongnu.org; Mon, 19 May 2014 21:03:03 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4K13072015318
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 21:03:01 -0400
Date: Tue, 20 May 2014 09:03:11 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140520010311.GA7688@T430.nay.redhat.com>
References: <1400502255-9784-1-git-send-email-famz@redhat.com>
	<20140519144029.GD4060@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140519144029.GD4060@noname.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, 05/19 16:40, Kevin Wolf wrote:
> Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben:
> > We should allow testing this on tmpfs. Any cache setting in iotests
> > should try to obey $CACHEMODE.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> Should we set _default_cache_mode=none then at least?

Yes we should set a default. We use _default_cache_mode=writethrough elsewhere,
why use none over writethrough here?

>                                                       We should probably
> also refuse to run with unsafe.

OK, I'll add _supported_cache_modes.

Fam

> >  tests/qemu-iotests/091 | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
> > index 384b3ac..a7deea8 100755
> > --- a/tests/qemu-iotests/091
> > +++ b/tests/qemu-iotests/091
> > @@ -59,13 +59,13 @@ echo === Starting QEMU VM1 ===
> >  echo
> >  
> >  qemu_comm_method="monitor"
> > -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk
> > +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk
> >  h1=$QEMU_HANDLE
> >  
> >  echo
> >  echo === Starting QEMU VM2 ===
> >  echo
> > -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk \
> > +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk \
> >               -incoming "exec: cat '${MIG_FIFO}'"
> >  h2=$QEMU_HANDLE
> >  
> > -- 
> > 1.9.2
> >