From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1Wmdht-0001rQ-PB
	for qemu-devel@nongnu.org; Tue, 20 May 2014 02:39:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1Wmdhk-0003HP-Mu
	for qemu-devel@nongnu.org; Tue, 20 May 2014 02:39:25 -0400
Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:50280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marc.mari.barcelo@gmail.com>) id 1Wmdhk-0003HK-Gd
	for qemu-devel@nongnu.org; Tue, 20 May 2014 02:39:16 -0400
Received: by mail-wi0-f175.google.com with SMTP id f8so5329091wiw.14
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 23:39:15 -0700 (PDT)
Date: Tue, 20 May 2014 08:39:11 +0200
From: Marc =?UTF-8?B?TWFyw60=?= <marc.mari.barcelo@gmail.com>
Message-ID: <20140520083911.51435595@crunchbang>
In-Reply-To: <537A7286.8000204@redhat.com>
References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com>
	<1400367823-32610-14-git-send-email-marc.mari.barcelo@gmail.com>
	<537A7286.8000204@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to
 QEMU_DPRINTF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org, Andreas =?UTF-8?B?RsOkcmJl?= =?UTF-8?B?cg==?= <afaerber@suse.de>

El Mon, 19 May 2014 15:07:18 -0600
Eric Blake <eblake@redhat.com> escribi=C3=B3:
> On 05/17/2014 05:03 PM, Marc Mar=C3=AD wrote:
> > Modify debug macros to have the same format through the codebase
> > and use regular ifs instead of ifdef.
> >=20
> > As the debug printf is always put in code, some formats had to be
> > changed to avoid warnings treated as errors at compile time..
> >=20
> > Signed-off-by: Marc Mar=C3=AD <marc.mari.barcelo@gmail.com>
> > ---
> >  hw/isa/vt82c686.c |   12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >=20
>=20
> > =20
> > -    DPRINTF("superio_ioport_writeb  address 0x%x  val 0x%x\n",
> > addr, data);
> > +    DPRINTF("superio_ioport_writeb address 0x%" PRIx64 "  val 0x%"
> > PRIx64 "\n",
>=20
> Any reason you shortened one double space but left the other intact?
> I would have expected both or none.
>=20

That's a typo. I wanted to left it as it was (double space in both
places).