From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39123)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Wmfhz-00034F-Q0
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:47:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Wmfht-0001b9-M4
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:47:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1Wmfht-0001av-EK
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:47:33 -0400
Date: Tue, 20 May 2014 09:47:26 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20140520084725.GA2538@work-vm>
References: <1400518826-19144-1-git-send-email-dgilbert@redhat.com>
	<1400571640.10626.7.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1400571640.10626.7.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of
 VMWare ioport emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: armbru@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com, rjones@redhat.com

* Gerd Hoffmann (kraxel@redhat.com) wrote:
> >      /* init basic PC hardware */
> > -    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(),
> > -        0x4);
> > +    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > +                         !qemu_opt_get_bool(qemu_get_machine_opts(), "vmport",
> > +                                            true) || xen_enabled(), 0x4);
> 
> pc_basic_device_init
>   (isa_bus, gsi, &rtc_state, &floppy,
>    !qemu_opt_get_bool(qemu_get_machine_opts(),"vmport",!xen_enabled()),
>    0x4);
> 
> ?
> 
> This makes vmport switchable on xen too, with traditional behavior being
> the default (off on xen, on otherwise).

Yes I guess that would work (although documenting it would be a little hairy);
however, does anyone understand the reasons it's disabled in the Xen world?

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK