From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40074)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WmfmX-0005mc-DE
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:52:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WmfmR-0002yl-9L
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:52:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WmfmR-0002yf-1T
	for qemu-devel@nongnu.org; Tue, 20 May 2014 04:52:15 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4K8qDE1029244
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 20 May 2014 04:52:13 -0400
Date: Tue, 20 May 2014 10:52:11 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140520085211.GB4440@noname.redhat.com>
References: <1400502255-9784-1-git-send-email-famz@redhat.com>
	<20140519144029.GD4060@noname.redhat.com>
	<20140520010311.GA7688@T430.nay.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140520010311.GA7688@T430.nay.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 20.05.2014 um 03:03 hat Fam Zheng geschrieben:
> On Mon, 05/19 16:40, Kevin Wolf wrote:
> > Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben:
> > > We should allow testing this on tmpfs. Any cache setting in iotests
> > > should try to obey $CACHEMODE.
> > > 
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > 
> > Should we set _default_cache_mode=none then at least?
> 
> Yes we should set a default. We use _default_cache_mode=writethrough elsewhere,
> why use none over writethrough here?

I think the test case set cache=none originally because it's a migration
test and this is the recommended setting for migration. As long as we're
on localhost, writethrough should be fine, though, so it's probably not
strictly necessary.

> >                                                       We should probably
> > also refuse to run with unsafe.
> 
> OK, I'll add _supported_cache_modes.

Thanks.

Kevin