From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>,
aliguori@amazon.com, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation
Date: Tue, 20 May 2014 10:18:03 +0100 [thread overview]
Message-ID: <20140520091802.GP1302@redhat.com> (raw)
In-Reply-To: <20140520084725.GA2538@work-vm>
On Tue, May 20, 2014 at 09:47:26AM +0100, Dr. David Alan Gilbert wrote:
> * Gerd Hoffmann (kraxel@redhat.com) wrote:
> > > /* init basic PC hardware */
> > > - pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(),
> > > - 0x4);
> > > + pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > > + !qemu_opt_get_bool(qemu_get_machine_opts(), "vmport",
> > > + true) || xen_enabled(), 0x4);
> >
> > pc_basic_device_init
> > (isa_bus, gsi, &rtc_state, &floppy,
> > !qemu_opt_get_bool(qemu_get_machine_opts(),"vmport",!xen_enabled()),
> > 0x4);
> >
> > ?
> >
> > This makes vmport switchable on xen too, with traditional behavior being
> > the default (off on xen, on otherwise).
>
> Yes I guess that would work (although documenting it would be a little hairy);
> however, does anyone understand the reasons it's disabled in the Xen world?
It was disabled in this patch. The commit message is saying that
vmport cannot work in Xen, but I'm not exactly clear why.
commit 1611977c3d8fdbdac6090cbd1f5555cee4aed6d9
Author: Anthony PERARD <anthony.perard@citrix.com>
Date: Tue May 3 17:06:54 2011 +0100
pc, Disable vmport initialisation with Xen.
This is because there is not synchronisation of the vcpu register
between Xen and QEMU, so vmport can't work properly.
This patch introduces no_vmport parameter to pc_basic_device_init.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
next prev parent reply other threads:[~2014-05-20 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:00 [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation Dr. David Alan Gilbert (git)
2014-05-19 17:03 ` Richard W.M. Jones
2014-05-20 7:40 ` Gerd Hoffmann
2014-05-20 8:47 ` Dr. David Alan Gilbert
2014-05-20 9:18 ` Richard W.M. Jones [this message]
2014-05-20 10:10 ` Gerd Hoffmann
2014-09-25 13:40 ` Slutz, Donald Christopher
2014-09-25 15:07 ` Dr. David Alan Gilbert
2014-09-25 17:47 ` Slutz, Donald Christopher
2014-09-25 18:00 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520091802.GP1302@redhat.com \
--to=rjones@redhat.com \
--cc=aliguori@amazon.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).