From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmk3H-0007rU-2g for qemu-devel@nongnu.org; Tue, 20 May 2014 09:25:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmk3B-0003dB-15 for qemu-devel@nongnu.org; Tue, 20 May 2014 09:25:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmk3A-0003cp-Mj for qemu-devel@nongnu.org; Tue, 20 May 2014 09:25:48 -0400 Date: Tue, 20 May 2014 15:25:41 +0200 From: Stefan Hajnoczi Message-ID: <20140520132541.GD22753@stefanha-thinkpad.redhat.com> References: <1400507236-14945-1-git-send-email-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400507236-14945-1-git-send-email-jiri@resnulli.us> Subject: Re: [Qemu-devel] [patch qemu] vmxnet3: fix msix vectors unuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jiri Pirko Cc: dmitry@daynix.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, dgilbert@redhat.com, mst@redhat.com On Mon, May 19, 2014 at 03:47:16PM +0200, Jiri Pirko wrote: > In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with > VMXNET3_MAX_INTRS. That is not correct since vector of > value VMXNET3_MAX_INTRS was never used. Also all the used vectors > are not un-used. So call vmxnet3_unuse_msix_vectors() instead which > does the correct job. > > Signed-off-by: Jiri Pirko > --- > hw/net/vmxnet3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan