From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmkB6-0003Jr-8z for qemu-devel@nongnu.org; Tue, 20 May 2014 09:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmkB1-0005sT-G3 for qemu-devel@nongnu.org; Tue, 20 May 2014 09:34:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmkB1-0005rj-7k for qemu-devel@nongnu.org; Tue, 20 May 2014 09:33:55 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4KDXsQO018011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 20 May 2014 09:33:54 -0400 Date: Tue, 20 May 2014 15:33:48 +0200 From: Stefan Hajnoczi Message-ID: <20140520133348.GE22753@stefanha-thinkpad.redhat.com> References: <1400514961-30472-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400514961-30472-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix memory leak in COW error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, mreitz@redhat.com On Mon, May 19, 2014 at 05:56:01PM +0200, Kevin Wolf wrote: > This triggers if bs->drv becomes NULL in a concurrent request. This is > currently only the case when corruption prevention kicks in (i.e. at > most once per image, and after that it produces I/O errors). > > Signed-off-by: Kevin Wolf > --- > block/qcow2-cluster.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan