From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wn76x-00086s-D0
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:03:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wn76p-0004MD-GB
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:03:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Wn76p-0004LV-87
	for qemu-devel@nongnu.org; Wed, 21 May 2014 10:03:07 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LE35gn004068
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 21 May 2014 10:03:06 -0400
Date: Wed, 21 May 2014 16:03:03 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140521140303.GG6619@stefanha-thinkpad.redhat.com>
References: <1400565880-13409-1-git-send-email-famz@redhat.com>
	<1400565880-13409-7-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1400565880-13409-7-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in
	BlockDriverState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, armbru@redhat.com, jcody@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, pbonzini@redhat.com

On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
> diff --git a/block/mirror.c b/block/mirror.c
> index 1c38aa8..6a53d79 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -499,6 +499,7 @@ immediate_exit:
>               * trigger the unref from the top one */
>              BlockDriverState *p = s->base->backing_hd;
>              s->base->backing_hd = NULL;
> +            bdrv_op_unblock_all(p, s->base->backing_blocker);
>              bdrv_unref(p);
>          }
>      }

Would be cleaner to call bdrv_set_backing_hd(s->base, NULL) here instead
of open coding it.

Stefan