From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, armbru@redhat.com, jcody@redhat.com,
hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com,
imain@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState
Date: Wed, 21 May 2014 16:06:38 +0200 [thread overview]
Message-ID: <20140521140638.GH6619@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1400565880-13409-7-git-send-email-famz@redhat.com>
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
> This makes use of op_blocker and blocks all the operations except for
> commit target, on each BlockDriverState->backing_hd.
>
> The asserts for op_blocker in bdrv_swap are removed because with this
> change, the target of block commit has at least the backing blocker of
> its child, so the assertion is not true. Callers should do their check.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 22 ++++++++++++++++++----
> block/mirror.c | 1 +
> include/block/block_int.h | 3 +++
> 3 files changed, 22 insertions(+), 4 deletions(-)
IMO it would be nice to split the series after this patch.
The op_blocker stuff looks solid and the series is at v20. Let's handle
the rest of the changes in separate, smaller series that can be easily
digested.
Stefan
next prev parent reply other threads:[~2014-05-21 14:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 6:04 [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 01/15] block: Add BlockOpType enum Fam Zheng
2014-05-21 12:28 ` Stefan Hajnoczi
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 02/15] block: Introduce op_blockers to BlockDriverState Fam Zheng
2014-05-21 12:28 ` Stefan Hajnoczi
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 03/15] block: Replace in_use with operation blocker Fam Zheng
2014-05-21 12:46 ` Stefan Hajnoczi
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller Fam Zheng
2014-05-20 11:43 ` Jeff Cody
2014-05-21 1:36 ` Fam Zheng
2014-05-21 4:34 ` Jeff Cody
2014-05-21 6:08 ` Fam Zheng
2014-05-21 13:13 ` Stefan Hajnoczi
2014-05-21 13:17 ` Jeff Cody
2014-05-21 14:04 ` Jeff Cody
2014-05-21 13:20 ` Stefan Hajnoczi
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd() Fam Zheng
2014-05-21 13:56 ` Stefan Hajnoczi
2014-05-21 14:17 ` Jeff Cody
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState Fam Zheng
2014-05-21 14:03 ` Stefan Hajnoczi
2014-05-21 14:24 ` Jeff Cody
2014-05-21 14:37 ` Fam Zheng
2014-05-22 16:57 ` Jeff Cody
2014-05-21 14:06 ` Stefan Hajnoczi [this message]
2014-05-21 14:49 ` Markus Armbruster
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 07/15] block: Parse "backing" option to reference existing BDS Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 08/15] block: Support dropping active in bdrv_drop_intermediate Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 09/15] stream: Use bdrv_drop_intermediate and drop close_unused_images Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 10/15] commit: Use bdrv_drop_intermediate Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 11/15] qmp: Add command 'blockdev-backup' Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 12/15] block: Allow backup on referenced named BlockDriverState Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 13/15] block: Add blockdev-backup to transaction Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 14/15] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-05-20 6:04 ` [Qemu-devel] [PATCH v20 15/15] qemu-iotests: Image fleecing test case 089 Fam Zheng
2018-06-29 18:00 ` [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD Eric Blake
2018-06-29 18:34 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521140638.GH6619@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=hbrock@redhat.com \
--cc=imain@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).