From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn7AN-000830-SN for qemu-devel@nongnu.org; Wed, 21 May 2014 10:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn7AH-0005nh-A6 for qemu-devel@nongnu.org; Wed, 21 May 2014 10:06:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn7AH-0005na-2M for qemu-devel@nongnu.org; Wed, 21 May 2014 10:06:41 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LE6exu002018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 21 May 2014 10:06:40 -0400 Date: Wed, 21 May 2014 16:06:38 +0200 From: Stefan Hajnoczi Message-ID: <20140521140638.GH6619@stefanha-thinkpad.redhat.com> References: <1400565880-13409-1-git-send-email-famz@redhat.com> <1400565880-13409-7-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400565880-13409-7-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, armbru@redhat.com, jcody@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, pbonzini@redhat.com On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote: > This makes use of op_blocker and blocks all the operations except for > commit target, on each BlockDriverState->backing_hd. > > The asserts for op_blocker in bdrv_swap are removed because with this > change, the target of block commit has at least the backing blocker of > its child, so the assertion is not true. Callers should do their check. > > Signed-off-by: Fam Zheng > --- > block.c | 22 ++++++++++++++++++---- > block/mirror.c | 1 + > include/block/block_int.h | 3 +++ > 3 files changed, 22 insertions(+), 4 deletions(-) IMO it would be nice to split the series after this patch. The op_blocker stuff looks solid and the series is at v20. Let's handle the rest of the changes in separate, smaller series that can be easily digested. Stefan