From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn7v3-0002DM-Lv for qemu-devel@nongnu.org; Wed, 21 May 2014 10:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn7ux-0001ky-Sc for qemu-devel@nongnu.org; Wed, 21 May 2014 10:55:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn7ux-0001jY-KM for qemu-devel@nongnu.org; Wed, 21 May 2014 10:54:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LEssh5025000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 21 May 2014 10:54:55 -0400 Date: Wed, 21 May 2014 16:54:52 +0200 From: Stefan Hajnoczi Message-ID: <20140521145452.GM6619@stefanha-thinkpad.redhat.com> References: <1400618599-27889-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1400618599-27889-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] iotests: Use _img_info in test 089 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org On Tue, May 20, 2014 at 10:43:19PM +0200, Max Reitz wrote: > Currently, test 089 uses $QEMU_IMG info manually in order to obtain the > according output. However, the iotests should generally use _img_info as > this filters out more irrelevant information such as the host image size > or format specific information. Therefore, test 089 should use _img_info > as well. > > Signed-off-by: Max Reitz > Reported-by: Kevin Wolf > --- > This is a follow-up patch for: > [PATCH v3 4/4] iotests: Add test for the JSON protocol > --- > tests/qemu-iotests/089 | 3 +-- > tests/qemu-iotests/089.out | 4 ---- > 2 files changed, 1 insertion(+), 6 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan