From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WnHYD-000377-3o
	for qemu-devel@nongnu.org; Wed, 21 May 2014 21:12:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WnHY8-00070j-BC
	for qemu-devel@nongnu.org; Wed, 21 May 2014 21:12:05 -0400
Received: from mail-pd0-x230.google.com ([2607:f8b0:400e:c02::230]:64554)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1WnHY8-00070a-4S
	for qemu-devel@nongnu.org; Wed, 21 May 2014 21:12:00 -0400
Received: by mail-pd0-f176.google.com with SMTP id p10so1912091pdj.21
	for <qemu-devel@nongnu.org>; Wed, 21 May 2014 18:11:59 -0700 (PDT)
Date: Thu, 22 May 2014 01:12:31 +0000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140522011231.GH30982@hostname>
References: <1400491383-6725-1-git-send-email-edgar.iglesias@gmail.com>
	<1400491383-6725-22-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA-tSzhoJ9WvxkorStXe5eKpPuQOJoG6ctpTFJuQQDZDgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-tSzhoJ9WvxkorStXe5eKpPuQOJoG6ctpTFJuQQDZDgA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 21/22] RFC: target-arm: A32: Use
 get_mem_index for load/stores
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, John Williams <john.williams@xilinx.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On Wed, May 21, 2014 at 08:27:52PM +0100, Peter Maydell wrote:
> On 19 May 2014 10:23, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> >
> > Avoid using IS_USER directly as the MMU-idx to simplify future
> > changes to the MMU layout.
> >
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> I think this makes sense; the bits involving the ldrt/strt handling
> are a little ugly after this change but we could probably clean
> that up later.

Thanks, I'll squash this into v4 then!

Cheers,
Edgar