From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] dataplane: Enable "scsi=on"
Date: Thu, 22 May 2014 14:48:44 +0200 [thread overview]
Message-ID: <20140522124844.GF12978@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1400744232-29173-1-git-send-email-famz@redhat.com>
On Thu, May 22, 2014 at 03:37:10PM +0800, Fam Zheng wrote:
> This makes the SG_IO code of non-dataplane available to dataplane, so that
> dataplane can use to allow scsi=on.
>
> v2:
> [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi.
> [2/2] Pass conf to virtio_blk_handle_scsi_req.
>
> Fam
>
>
> Fam Zheng (2):
> virtio-blk: Factor out virtio_blk_handle_scsi_req from
> virtio_blk_handle_scsi
> dataplane: Support VIRTIO_BLK_T_SCSI_CMD
>
> hw/block/dataplane/virtio-blk.c | 18 +++++----
> hw/block/virtio-blk.c | 83 +++++++++++++++++++++++------------------
> include/hw/virtio/virtio-blk.h | 4 ++
> 3 files changed, 60 insertions(+), 45 deletions(-)
I wonder if it's okay to use synchronous bdrv_ioctl() but the existing
code already does it. It would be bad to block the thread.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2014-05-22 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 7:37 [Qemu-devel] [PATCH v2 0/2] dataplane: Enable "scsi=on" Fam Zheng
2014-05-22 7:37 ` [Qemu-devel] [PATCH v2 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi Fam Zheng
2014-05-22 7:58 ` Paolo Bonzini
2014-05-22 7:37 ` [Qemu-devel] [PATCH v2 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD Fam Zheng
2014-05-22 12:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522124844.GF12978@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).