From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46531)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnSQZ-0001zS-Tk
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:49:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnSQS-0004bc-EF
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:48:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61749)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnSQS-0004bN-6U
	for qemu-devel@nongnu.org; Thu, 22 May 2014 08:48:48 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4MCmkv7024955
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 22 May 2014 08:48:46 -0400
Date: Thu, 22 May 2014 14:48:44 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140522124844.GF12978@stefanha-thinkpad.redhat.com>
References: <1400744232-29173-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1400744232-29173-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] dataplane: Enable "scsi=on"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Thu, May 22, 2014 at 03:37:10PM +0800, Fam Zheng wrote:
> This makes the SG_IO code of non-dataplane available to dataplane, so that
> dataplane can use to allow scsi=on.
> 
> v2:
>     [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi.
>     [2/2] Pass conf to virtio_blk_handle_scsi_req.
> 
> Fam
> 
> 
> Fam Zheng (2):
>   virtio-blk: Factor out virtio_blk_handle_scsi_req from
>     virtio_blk_handle_scsi
>   dataplane: Support VIRTIO_BLK_T_SCSI_CMD
> 
>  hw/block/dataplane/virtio-blk.c | 18 +++++----
>  hw/block/virtio-blk.c           | 83 +++++++++++++++++++++++------------------
>  include/hw/virtio/virtio-blk.h  |  4 ++
>  3 files changed, 60 insertions(+), 45 deletions(-)

I wonder if it's okay to use synchronous bdrv_ioctl() but the existing
code already does it.  It would be bad to block the thread.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>