From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44947)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnU9A-0002Of-O1
	for qemu-devel@nongnu.org; Thu, 22 May 2014 10:39:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnU92-00052p-3R
	for qemu-devel@nongnu.org; Thu, 22 May 2014 10:39:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WnU91-00052e-Qv
	for qemu-devel@nongnu.org; Thu, 22 May 2014 10:38:56 -0400
Date: Thu, 22 May 2014 16:38:35 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140522143835.GA21238@stefanha-thinkpad.redhat.com>
References: <1400703772-3324-1-git-send-email-stefanha@redhat.com>
	<1400703772-3324-2-git-send-email-stefanha@redhat.com>
	<CAEgOgz7Cs12dYjpFkg15LeHFv2rTPPbRpcjeB+8Lio22SzL7KA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz7Cs12dYjpFkg15LeHFv2rTPPbRpcjeB+8Lio22SzL7KA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Frederic Konrad <fred.konrad@greensocs.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Andreas Faerber <afaerber@suse.de>

On Fri, May 23, 2014 at 12:02:44AM +1000, Peter Crosthwaite wrote:
> On Thu, May 22, 2014 at 6:22 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > +void object_property_add_alias(Object *obj, const char *name,
> > +                               Object *target_obj, const char *target_name,
> > +                               Error **errp)
> > +{
> > +    AliasProperty *prop;
> > +    ObjectProperty *target_prop;
> > +
> > +    target_prop = object_property_find(target_obj, target_name, errp);
> > +    if (!target_prop) {
> > +        return;
> 
> Not sure silent failure is right here. This should perhaps populate
> errp and then caller can decide to assert/ignore/report as needed.

object_property_find() already populates errp so the error is not
silent.  Did you miss the errp argument to object_property_find()?

Stefan