Re: [Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 22 May 2014 02:33:45 +0000
"chen.fan.fnst@cn.fujitsu.com" <chen.fan.fnst@cn.fujitsu.com> wrote:

> Hi,
>    I think if we want to use 'device/device_add' to implement CPU,
> we must do some check before qemu_init_vcpu(). how can we to do that?
What check exactly would you like to perform?

For target-i38 you can look for kvm_check_features_against_host() in
x86_cpu_realizefn() doing check before qemu_init_vcpu().

> 
> Thanks,
> Chen
> 
> On Tue, 2014-05-13 at 18:08 +0800, Chen Fan wrote: 
> > this patches tried to make cpu hotplug with device_add, 
> > and made -device foo-x86_64-cpu available，also we can
> > set apic-id property with command line, if without setting
> > apic-id property, we added first unoccupied apic id as the
> > default new apic id. and hotplug cpu with device_add, we
> > must make check of APIC ID after cpu object initialization
> > that was different from 'cpu_add' command which check 'ids'
> > at the beginning.
> > 
> > Chen Fan (3):
> >   using CPUMASK bitmaps to calculate cpu index
> >   cpu: introduce CpuTopoInfo structure for argument simplification
> >   cpu: add device_add foo-x86_64-cpu support
> > 
> >  exec.c                  |  9 +++--
> >  include/qom/cpu.h       | 11 ++++++
> >  include/sysemu/sysemu.h |  7 ----
> >  qdev-monitor.c          | 11 ++++++
> >  target-i386/cpu.c       | 91 ++++++++++++++++++++++++++++++++++++++++++++++++-
> >  target-i386/topology.h  | 51 ++++++++++++++++++---------
> >  6 files changed, 151 insertions(+), 29 deletions(-)
> > 
>