From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>,
mjt@tls.msk.ru, Micael Roth <mdroth@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars
Date: Fri, 23 May 2014 10:37:08 +0800 [thread overview]
Message-ID: <20140523023708.GA1668@T430.nay.redhat.com> (raw)
In-Reply-To: <1399987445-6042-1-git-send-email-famz@redhat.com>
On Tue, 05/13 21:24, Fam Zheng wrote:
> The macro unnest-vars is the most important, complicated but hard to
> track magic in QEMU's build system.
>
> Rewrite it in a (hopefully) clearer way, with more comments, to make it
> easier to understand and maintain.
>
> Remove DSO_CFLAGS and module-objs-m that are not used.
>
> A bonus fix of this version is, per object variables are properly
> protected in save-objs and load-objs, before including sub-dir
> Makefile.objs, just as nested variables are. So the occasional same
> object name from different directory levels won't step on each other's
> foot.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Ping?
next prev parent reply other threads:[~2014-05-23 2:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 13:24 [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars Fam Zheng
2014-05-23 2:37 ` Fam Zheng [this message]
2014-05-23 13:22 ` Paolo Bonzini
2014-05-23 13:33 ` Fam Zheng
2014-05-23 13:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140523023708.GA1668@T430.nay.redhat.com \
--to=famz@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).