From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnfM5-0004Dy-Qk for qemu-devel@nongnu.org; Thu, 22 May 2014 22:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnfLz-0005tW-K4 for qemu-devel@nongnu.org; Thu, 22 May 2014 22:37:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnfLz-0005tL-CD for qemu-devel@nongnu.org; Thu, 22 May 2014 22:37:03 -0400 Date: Fri, 23 May 2014 10:37:08 +0800 From: Fam Zheng Message-ID: <20140523023708.GA1668@T430.nay.redhat.com> References: <1399987445-6042-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1399987445-6042-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Richard Henderson , mjt@tls.msk.ru, Micael Roth , Paolo Bonzini On Tue, 05/13 21:24, Fam Zheng wrote: > The macro unnest-vars is the most important, complicated but hard to > track magic in QEMU's build system. > > Rewrite it in a (hopefully) clearer way, with more comments, to make it > easier to understand and maintain. > > Remove DSO_CFLAGS and module-objs-m that are not used. > > A bonus fix of this version is, per object variables are properly > protected in save-objs and load-objs, before including sub-dir > Makefile.objs, just as nested variables are. So the occasional same > object name from different directory levels won't step on each other's > foot. > > Signed-off-by: Fam Zheng Ping?